Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating links in the contributing docs to point to correct locations #1234

Merged
merged 6 commits into from
Jul 28, 2022
Merged

updating links in the contributing docs to point to correct locations #1234

merged 6 commits into from
Jul 28, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Jul 27, 2022

problem

while reading through the contributing docs, i noticed the links to the project license and code of conduct were broken. they're pointing to files in places that they don't exist

i also noticed there's another copy of some contributing docs in the contributor-docs/README.md file, which had bad links for the same files, bad links to fork and compare, and bad links for the documentation and testing bits

solution

this PR adjusts the links in both of the contributing docs mentioned above, setting all the currently broken links to the full url of the document or repo page instead of relying on the interpolation of links at build / run time.

@mxriverlynn mxriverlynn requested review from a team and jonrohan July 27, 2022 19:34
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

🦋 Changeset detected

Latest commit: 4b83efd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 🎉 Just a few suggestions.

contributor-docs/README.md Outdated Show resolved Hide resolved
contributor-docs/README.md Outdated Show resolved Hide resolved
mxriverlynn and others added 2 commits July 28, 2022 07:13
Co-authored-by: Cameron Dutro <camertron@gmail.com>
Co-authored-by: Cameron Dutro <camertron@gmail.com>
@jonrohan jonrohan merged commit ee04a4a into primer:main Jul 28, 2022
@mxriverlynn mxriverlynn deleted the correcting-links-in-contributing-doc branch July 28, 2022 17:36
@primer-css primer-css mentioned this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants